UI proposal: "Smart-Buttons" prevent accidental dangerous changes of the oC configuration

Sometimes, it is too easy to modify dangerous settings by accident. I heard of numerous issues where oC admins broke their instance by unintentionally clicking in the LDAP settings.

Here is my proposal for improvement:

  • As soon any setting is modified, an indicator will be added to the bottom to remind the admin that something has changed.
  • With more changes, more indicators from different groups will show up.
  • To bring the changes to production, the admin have to Apply them.

I also think we should have 'OK' or 'Apply' buttons.
The current behaviour is more messy to implement for developers and as you said potentially dangerous.
Also you might have been kicked out of your internet connection and then don't know if you did a setting

  • Keep the current behaviour
  • Introduce smart buttons (see above)
  • Introduce always visible 'OK' or 'Apply' buttons
  • I don't care


Choose up to 2 options

Also an issue with the external storage configuration, especially that it saves and creates storage entries before you finished typing if you happen to take a break while typing in a path...

External storage issue: https://github.com/owncloud/core/issues/22479

1 Like

I may be oldfashioned, but I expect an explicit OK or APPLY button, and maybe a 'You have unsaved changes' warning, when leaving without APPLY. These are admin settings. They do not need to follow any modern 'click in empty space to save' ideas, IMHO. :slight_smile:


Please also vote if you don't care, so we don't have results like in totalitarian states :slight_smile:

The issue goes throughout however, there are also settings a user has to do, like passwords. Of course then there are things like the sharing action where I would not want to press apply. Or when a user is added to a group. IMHO we need consistency throughout and logic when which behaviour exists and why.

I would be for a ok or apply button, too.

Smart-Buttons seem like a good idea for critical forms. But i would think that it depends on the work behind this.

Tracking dirty states can be easy with modern frameworks like ng2 or react, but we are not there yet. This means tracking dirty states in our forms might be a lot of work for little benefit over the always visible buttons.

We have to figure out if the additional work is worth the benefit.

Please! please!please! a confirmation bottom would be great

Additionally if there are some changes in the expert tab should be a reminding that says:

"Making changes in the expert tab in production system will be create big problems that can't be repaired later"

(Or similar) :wink:


All dangerous actions that can not be undo should have a cleaner UI, confirmation button, alerts..

As Delete a file, just below the download button.. really easy to delete the file instead.

We have a wonderful trash-bin for recovery most of them, but if you delete a file that was shared with you.. :scream: we will lose access to it

Related undo actions https://github.com/owncloud/core/issues/26296

@guruz Do you have enough votes?

1 Like

We could go ever further and implement different stages of severity where confirming changes will require more action on the changers side.

Low level of confirmation

A simple Save (changes) button accepts changes.
e.g. Change "Full Name" in personal settings

= 1 click

Medium level of confirmation

Clicking the Save (changes) button triggers a confirmation window/overlay with an yes or no option.

= 2 clicks

High level of confirmation

Clicking the Save (changes) button triggers a confirmation window/overlay, reminding you of the consequences of your action and requiring you to input a word (lets say confirm) into a field and clicking yes again.

= 2 clicks + 1 txt input

These the leves can be used all around OC and even extended if needed. A simple DATA Tag added to the save button could do the trick. (e.g. data-conf-level="1") and would require no further implementation on the dev. side.

Take a quick look @ LDAP Gui Save Button Proposal Mockup

1 Like

We should keep the smart button idea in mind tho!

No need to make it this complicated. Keep it simple.

1 Like