Nextcloud/bookmark app calles undefined methode

theScrabi · February 10, 2017, 9:21pm

Hello,

this line here part of the nextcloud/bookmark app runned under my owncloud 9.1 installation makes my owncloud fail. It says that this function is not defined. May this be something that is only available on Nextcloud? That would be strange. I always thought they would just take the owncloud core and don't modify it.

rgds Schabi

anon81984126 · February 11, 2017, 8:19am

Hi,

shortly after the fork Nextcloud introduced the first API break [1] for apps registering stuff at the admin backend followed by additional changes for 3rdparty apps in [2] and now your mentioned third problem in [3].

Something like this is causing:

Double of work for app developers if they want to keep compatibility with ownCloud and Nextcloud
App developer which can't handle this additional effort to choose sides between oC and Nc
the need of forking apps to make them compatible with oC again

IMHO this is one thing where Nc is trying to pull users on their side by introducing such incompatibilities / API breaks which makes it impossible for oC users using apps written for Nc.

Thats one of many reasons why i dislike the Nc project and why i would never move my installation to Nc.

If they wanted to keep app compatibility between oC and Nc they could have done this. Instead a community gets splitted and misused to taking sides between both.

[1]

[2]

[3]

github.com

nextcloud/bookmarks/blob/b07d2377135507e0983056f62819cee71ba7ecac/templates/main.php#L22


* Copyright (c) 2011 Arthur Schiwon <blizzz@arthur-schiwon.de>
* This file is licensed under the Affero General Public License version 3 or
* later.
* See the COPYING-README file.
*/
$bookmarkleturl = $_['bookmarkleturl'];
$bookmarkletscript = bookmarklet($bookmarkleturl);


function bookmarklet($bookmarkleturl) {
	$l = \OC::$server->getL10N('bookmarks');
	$defaults = \OC::$server->getThemingDefaults();
	$blet = "javascript:(function(){var a=window,b=document,c=encodeURIComponent,e=c(document.title),d=a.open('";
	$blet .= $bookmarkleturl;
	$blet .= "?output=popup&url='+c(b.location)+'&title='+e,'bkmk_popup','left='+((a.screenX||a.screenLeft)+10)+',top='+((a.screenY||a.screenTop)+10)+',height=400px,width=550px,resizable=1,alwaysRaised=1');a.setTimeout(function(){d.focus()},300);})();";
	$help_msg = $l->t('Drag this to your browser bookmarks and click it, when you want to bookmark a webpage quickly:');
	$output = '<div id="bookmarklet_hint" class="bkm_hint">' . $help_msg . '</div><a class="button bookmarklet" href="' . $blet . '">' . $l->t('Add to ' . \OCP\Util::sanitizeHTML($defaults->getName())) . '</a>';
	return $output;
}
?>


<div id="app-navigation">

tflidd · July 1, 2017, 8:50am

There were some fixes on the owncloud version:

but it needs someone to backport more changes from upstream to this repo.